Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): search json path is incorrect when config.outDir is absolute #1844

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

liuwenzhuang
Copy link
Contributor

Summary

Serve search json will be failed when config.outDir is a absolute path, use same path join strategy from writeSearchIndex function instead.

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 6d3b7a7
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67ad5cb230f2070008603e72
😎 Deploy Preview https://deploy-preview-1844--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 67 (🔴 down 11 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter
Copy link
Member

Thanks❤, this indeed appears to be a corner case
Feel free to further test with the config.outputDir: absolutePath setting, submit PRs, and add more test cases to ensure stability of the functionality.

@SoonIter SoonIter merged commit 22eae2b into web-infra-dev:main Feb 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants