Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme)!: unify socialLinks to "@iconify-json/simple-icons", smaller style and size #1808

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Feb 5, 2025

Summary

weibo and lark have no "simple-icons", so preserve the old style

before

image

after

image

test links

[ { "icon": "lark", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "discord", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "facebook", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "github", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "instagram", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "linkedin", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "slack", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "x", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "twitter", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "youtube", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "wechat", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "qq", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "juejin", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "zhihu", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "bilibili", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "weibo", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "gitlab", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "X", "mode": "link", "content": "https://x.com/rspack_dev" }, { "icon": "bluesky", "mode": "link", "content": "https://x.com/rspack_dev" } ]

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 65b25d3
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67a3099a71333c0008b6d9f4
😎 Deploy Preview https://deploy-preview-1808--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter changed the title feat(theme)!: unify to "@iconify-json/simple-icons" and smaller style feat(theme)!: unify socialLinks to "@iconify-json/simple-icons" and smaller style Feb 5, 2025
@SoonIter SoonIter changed the title feat(theme)!: unify socialLinks to "@iconify-json/simple-icons" and smaller style feat(theme)!: unify socialLinks to "@iconify-json/simple-icons", smaller style and size Feb 5, 2025
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@SoonIter SoonIter merged commit e804392 into main Feb 5, 2025
9 checks passed
@SoonIter SoonIter deleted the social-icon branch February 5, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants