Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-default): remove unused twitter icon #1788

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

chenjiahan
Copy link
Member

Summary

Since #1316, Rspress will use the X icon for twitter.

We can remove the unused twitter icon to reduce bundle size.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 20b5103
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67977f997fdf730008eda3aa
😎 Deploy Preview https://deploy-preview-1788--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 enabled auto-merge (squash) January 27, 2025 12:45
@Timeless0911 Timeless0911 merged commit 9c8b214 into main Jan 27, 2025
8 checks passed
@Timeless0911 Timeless0911 deleted the twitter_icon_0127 branch January 27, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants