-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Settings #114
i18n: Settings #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just few details to improve.
@amanuela97 can you please rebase on beta and resolve conflicts? |
70af977
to
3a64d09
Compare
PR should be to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more things 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 99%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done!
* fix: translation for /settings * fix: tips, before, label grouped by fieldName * fix: changes made to translation for settings page * fix: restructured translation keys * fix: date keys capitalized * fix: Capitalize saturday and sunday
Demo: https://wedance-amanuela97.netlify.app/settings
Closes #81