Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: break sequencing #874

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ifplusor
Copy link

close #865

@chrisands
Copy link

@wbthomason can we merge it? Currently using ifplusor branch to work with vscode-neovim plugin.

@wbthomason
Copy link
Owner

@ifplusor @chrisands Sorry for taking so long to get to this! I'm mostly OK with merging, but I don't entirely understand what skip_lazy is meant to do - can you explain the intent in the context of #865?

@ifplusor
Copy link
Author

@ifplusor @chrisands Sorry for taking so long to get to this! I'm mostly OK with merging, but I don't entirely understand what skip_lazy is meant to do - can you explain the intent in the context of #865?

If a plugin is set to lazy load and the condition(by keys, by commands, by events, etc.) has not yet fired, skip it.

@ifplusor
Copy link
Author

However, I only check commands and keys, not events.

@wbthomason
Copy link
Owner

Ok, thanks - that was the source of my confusion (i.e. why just keys and commands). We should make that check for any remaining untriggered lazy loading, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loading conditional plugins break sequencing
3 participants