Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade black to fix conflict with Click 8.1 #44

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

sr-verde
Copy link
Contributor

Running tox fails due to a known conflict between black versions < 22.3 and Click 8.1.

tox -r -e format
.package recreate: /home/theus/git/other/flask-mailman/.tox/.package
.package installdeps: poetry-core>=1.0.0
format recreate: /home/theus/git/other/flask-mailman/.tox/format
format inst: /home/theus/git/other/flask-mailman/.tox/.tmp/package/1/flask_mailman-0.3.0.tar.gz
format installed: attrs==22.2.0,black==21.12b0,click==8.1.3,coverage==7.1.0,flake8==3.9.2,Flask==2.2.3,flask-mailman @ file:///home/theus/git/other/flask-mailman/.tox/.tmp/package/1/flask_mailman-0.3.0.tar.gz,iniconfig==2.0.0,isort==5.12.0,itsdangerous==2.1.2,Jinja2==3.1.2,MarkupSafe==2.1.2,mccabe==0.6.1,mkdocs-material-extensions==1.1.1,mypy-extensions==1.0.0,packaging==23.0,pathspec==0.11.0,platformdirs==3.0.0,pluggy==1.0.0,py==1.11.0,pycodestyle==2.7.0,pyflakes==2.3.1,pytest==6.2.5,pytest-cov==2.12.1,toml==0.10.2,tomli==1.2.3,typing_extensions==4.5.0,Werkzeug==2.2.3
format run-test-pre: PYTHONHASHSEED='560391681'
format run-test: commands[0] | isort flask_mailman
format run-test: commands[1] | black flask_mailman tests
Traceback (most recent call last):
  File "/home/theus/git/other/flask-mailman/.tox/format/bin/black", line 8, in <module>
    sys.exit(patched_main())
  File "/home/theus/git/other/flask-mailman/.tox/format/lib/python3.10/site-packages/black/__init__.py", line 1372, in patched_main
    patch_click()
  File "/home/theus/git/other/flask-mailman/.tox/format/lib/python3.10/site-packages/black/__init__.py", line 1358, in patch_click
    from click import _unicodefun
ImportError: cannot import name '_unicodefun' from 'click' (/home/theus/git/other/flask-mailman/.tox/format/lib/python3.10/site-packages/click/__init__.py)
ERROR: InvocationError for command /home/theus/git/other/flask-mailman/.tox/format/bin/black flask_mailman tests (exited with code 1)
________________________________________________ summary _________________________________________________
ERROR:   format: commands failed

This merge request fixes that by upgrading black to > 22.3.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 63.10% // Head: 63.10% // No change to project coverage 👍

Coverage data is based on head (2e4a62c) compared to base (5369264).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   63.10%   63.10%           
=======================================
  Files           9        9           
  Lines         580      580           
=======================================
  Hits          366      366           
  Misses        214      214           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@greyli greyli merged commit cff7dbf into waynerv:master Aug 20, 2023
@greyli
Copy link
Collaborator

greyli commented Aug 20, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants