-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scoped environment config loading #451
Scoped environment config loading #451
Conversation
Would this resolve #285? |
@navarr yes, I do think so. One could change the default image for a given service and |
@davidalger, could you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tdgroot Good job. It's looks very useful and provide ability to work not only with php 👍
When to expect this feature to be merged to stable release? |
Found out that the scoped loading was missing for the Mutagen configuration loading, so I added that! |
@davidalger please review this PR |
@ Maintainers Whats the status of the PR? +1 |
@davidalger Have you had a chance to review this yet? :) |
@davidalger what can I do to help to merge this PR? 🙏 |
Anyone still interested in this PR? @davidalger UP |
I believe that we can create community driven fork due to @davidalger lack of free time |
@Den4ik, actually, it's already there https://github.com/swiftotter/den/discussions/5 |
Port in wardenenv#451 Signed-off-by: Navarr <[email protected]>
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Port in #451 Signed-off-by: Navarr <[email protected]>
Manually merged from Den in 5a24ca7 |
This pull request allows developers to provide user-level and project-level customizations to Warden development environments. For example, if a developer wants to create a phpMyAdmin service for all environments, he could create a
~/.warden/environments/includes/db.base.yml
or perhaps in<project_dir>/.warden/environments/includes/db.base.yml
:It also allows developers to develop (and share) custom environment types, without having to edit Warden core files.