-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ZKP Section #999
Remove ZKP Section #999
Conversation
@tplooker I think we intend to refer to BBS eventually, assuming that is possible to do before the charter for the current WG ends, happy to help update this section in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this is where we had consensus on the Editor's call. I thought we had agreed to place a big warning at the top of the section noting that the section would be deleted/rewritten before entering Candidate Recommendation if there was no standardized and implemented ZKP mechanism (such as BBS) provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an Editor, and wasn't on that call, but I concur with the handling described by @msporny as his recollection of that call; i.e., the giant deletion is premature.
The issue was discussed in a meeting on 2023-01-11
View the transcript2.2. Remove ZKP Section (pr vc-data-model#999)See github pull request vc-data-model#999. Manu Sporny: Next PR is to remove the ZKP section.. |
At this stage I would much prefer a warning being added over removing the section entirely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a clean, easy-to-read specification that explains only the minimum of what implementers need to know to get started with Verifiable Credentials would greatly benefit in expanding and maturing the VC ecosystem at this stage.
There are enough documents surrounding vc-data-model that explain various adjacent concepts that are useful - e.g. use-cases, implementation guidelines, etc. - to where we can move current ZKP section (and maybe few other).
I understand why adding a warning might be an alternative, but I believe that moving this section to another related document would benefit the spec more.
We could say we will merge this PR only after this section is merged into another document (implementation considerations).
Moving the section to another document would probably be fine with me. When such a PR is active or merged, I will reconsider this PR, but lacking that relocation, I still want the warning instead of the deletion. |
Yes, we can merge this after this section is moved to the implementation guide. Waiting for a PR that does that before merging this one. |
The challenge with "moving this section to the implementation guide" is that this section includes normative requirements. |
@brentzundel wrote:
Ok, in that case, it seems like a warning "that we might delete this section if we don't have a ZKP mechanism by CR" would be what could achieve consensus, then? Either that, or we just hold this PR until such a normative spec that provides equivalent requirements (like the BBS cryptosuite) appears. I'm fine w/ doing either, though feel like a warning might be the best way to resolve this PR at the present. |
Warning issue works. |
I'd prefer to have the text of the issue approved by the working group before attempting to open another PR. Some options for the call: PROPOSAL: This section will be removed prior to CR if there are no active work items that are making use of its normative statements. PROPOSAL: This section might be removed prior to CR. The more I write these, the less I agree this is a good move.... the working group should not be holding onto 1.1 text in the hope that it will "one day" become relevant... especially if it contains normative statemetns that are untestable, and for which there are no active work items. |
How about re-writing the section and changing the title to "Selective disclosure and unlikability"? That would make the section more generic and broaden the scope from Zero Knowledge Proof schemes to other techniques. For example, signed objects with salted hashed claims could be described as an alternative for selective disclosure. There is a proposal on this in issue 939. |
Can we add a TODO in place? |
The issue was discussed in a meeting on 2023-01-25
View the transcript4.2. Remove ZKP Section (pr vc-data-model#999)See github pull request vc-data-model#999. Manu Sporny: looking for other folks to weigh in, otherwise just the folks conversing on the pr will contribute. Ted Thibodeau Jr.: don't think normative language should be a blocker - could move and change to informative language. Orie Steele: notes that the work done is preserved permenantly in 1.1. Ivan Herman: the fact that it is part of 1.1 will be "hidden" when 2.0 gets published.
Ivan Herman: question without knowing all tech details, is this urgent to do now? Not at CR point, maybe a flag is better? other options noting potential removal?.
Brent Zundel: as author (not chair) - the section needs significant reworking, removal likely, but removal at this time may be premature.
Manu Sporny: can try to put a warning in.
Kristina Yasuda: not a big fan of just a warning.
Manu Sporny: new PR for a new section intending to replace this section, that is shorter and attempts to capture the "spirit" of things in advance of BBS, non-normative for now, that can become normative later if appropriate.
Manu Sporny: begs for other folks to help out because his stack is overflowing, otherwise will eventually get to it. |
Closing in favor of #1026 |
The issue was discussed in a meeting on 2023-02-01
View the transcript3.2. (pr vc-data-model#999)See github pull request vc-data-model#999. Manu Sporny: PR 999 to remove ZKP section, there is another PR in the works that is more modern, we're waiting for that to be submitted, then we will look at both PRs side by side to determine which one we want to take.. |
See #863
In the future, if there is a ZKP format that the working group can refer to, such as:
We might define this section and refer to those items, if they can be referred to.
It was also noted, that the original text is preserved for all time in the v1 and v1.1 TRs.
Preview | Diff