Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change definition of embellished / core operator for maction and semantics #182

Closed
fred-wang opened this issue Jan 20, 2020 · 3 comments
Closed

Change definition of embellished / core operator for maction and semantics #182

fred-wang opened this issue Jan 20, 2020 · 3 comments
Labels
MathML Core Issues affecting the MathML Core specification MathML 4 Issues affecting the MathML 4 specification

Comments

@fred-wang
Copy link

This is similar to #160

Currently, the definitions refers to the "first in-flow child".

In general maction and semantics just have a single in-flow child so we can just use the same definitions as mrow-like and unknown elements. In particular that will allow to handle consistently maction, semantics, mrow, mstyle, mphantom, mpadded and unknown MathML elements and simplify implementations.
@NSoiffer NSoiffer mentioned this issue Jan 20, 2020
Closed
@fred-wang fred-wang changed the title Change definition of embellished core / operator for maction and semantics Change definition of embellished / core operator for maction and semantics Jan 20, 2020
@fred-wang
Copy link
Author

Consensus from 2020/01/21: approved.

fred-wang added a commit to w3c/mathml-core that referenced this issue Jan 21, 2020
@fred-wang
Embellished op: Treat maction/semantics like other mrow-like elements.
d714cf9 
See w3c/mathml#182
@NSoiffer
Copy link
Contributor

@fred-wang: can this be closed? If not, what's left to do?

@NSoiffer NSoiffer mentioned this issue Feb 24, 2020
Closed
fred-wang added a commit to web-platform-tests/wpt that referenced this issue Mar 21, 2020
@fred-wang
Update MathML tests for embellished operators.
54e99e1 
This commit updates tests after [1] [2]:

* merror, mprescripts, none, unknown are now treated as other mrow-like
  elements.
* maction and semantics are moved into a separate file and new tests
  added now that they are mrow-like elements with some hidden children.

[1] w3c/mathml#182
[2] w3c/mathml#183
@fred-wang fred-wang mentioned this issue Mar 21, 2020
Merged
@fred-wang
Copy link
Author

@fred-wang: can this be closed? If not, what's left to do?

We still need to update tests for embellished op. Doing it in web-platform-tests/wpt#22381

@fred-wang fred-wang added need tests Issues related to writing WPT tests MathML 4 Issues affecting the MathML 4 specification MathML Core Issues affecting the MathML Core specification labels Mar 21, 2020
fred-wang added a commit to web-platform-tests/wpt that referenced this issue Mar 22, 2020
@fred-wang
Update MathML tests for embellished operators. (#22381)
c38ae4a 
This commit updates tests after [1] [2]:

* merror, mprescripts, none, unknown are now treated as other mrow-like
  elements.
* maction and semantics are moved into a separate file and new tests
  added now that they are mrow-like elements with some hidden children.

[1] w3c/mathml#182
[2] w3c/mathml#183
@fred-wang fred-wang removed the need tests Issues related to writing WPT tests label Mar 22, 2020
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Mar 26, 2020
@fred-wang @moz-wptsync-bot
Bug 1624143 [wpt PR 22381] - Update MathML tests for embellished oper…
1c3982b 
…ators., a=testonly

Automatic update from web-platform-tests
Update MathML tests for embellished operators. (#22381)

This commit updates tests after [1] [2]:

* merror, mprescripts, none, unknown are now treated as other mrow-like
  elements.
* maction and semantics are moved into a separate file and new tests
  added now that they are mrow-like elements with some hidden children.

[1] w3c/mathml#182
[2] w3c/mathml#183
--

wpt-commits: c38ae4ac2e0af285deb06f33c75e1699d0718942
wpt-pr: 22381
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 26, 2020
@fred-wang @moz-wptsync-bot
Bug 1624143 [wpt PR 22381] - Update MathML tests for embellished oper…
141e25b 
…ators., a=testonly

Automatic update from web-platform-tests
Update MathML tests for embellished operators. (#22381)

This commit updates tests after [1] [2]:

* merror, mprescripts, none, unknown are now treated as other mrow-like
  elements.
* maction and semantics are moved into a separate file and new tests
  added now that they are mrow-like elements with some hidden children.

[1] w3c/mathml#182
[2] w3c/mathml#183
--

wpt-commits: c38ae4ac2e0af285deb06f33c75e1699d0718942
wpt-pr: 22381
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Mar 31, 2020
@marco-c
Bug 1624143 [wpt PR 22381] - Update MathML tests for embellished oper…
cc3633d 
…ators., a=testonly

Automatic update from web-platform-tests
Update MathML tests for embellished operators. (#22381)

This commit updates tests after [1] [2]:

* merror, mprescripts, none, unknown are now treated as other mrow-like
  elements.
* maction and semantics are moved into a separate file and new tests
  added now that they are mrow-like elements with some hidden children.

[1] w3c/mathml#182
[2] w3c/mathml#183
--

wpt-commits: c38ae4ac2e0af285deb06f33c75e1699d0718942
wpt-pr: 22381

UltraBlame original commit: 8e8fe19364e1c1ddc7d7ce589aa2fd8d8e23572c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Mar 31, 2020
@marco-c
Bug 1624143 [wpt PR 22381] - Update MathML tests for embellished oper…
4ba1b3e 
…ators., a=testonly

Automatic update from web-platform-tests
Update MathML tests for embellished operators. (#22381)

This commit updates tests after [1] [2]:

* merror, mprescripts, none, unknown are now treated as other mrow-like
  elements.
* maction and semantics are moved into a separate file and new tests
  added now that they are mrow-like elements with some hidden children.

[1] w3c/mathml#182
[2] w3c/mathml#183
--

wpt-commits: c38ae4ac2e0af285deb06f33c75e1699d0718942
wpt-pr: 22381

UltraBlame original commit: 8e8fe19364e1c1ddc7d7ce589aa2fd8d8e23572c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Mar 31, 2020
@marco-c
Bug 1624143 [wpt PR 22381] - Update MathML tests for embellished oper…
e81e6e1 
…ators., a=testonly

Automatic update from web-platform-tests
Update MathML tests for embellished operators. (#22381)

This commit updates tests after [1] [2]:

* merror, mprescripts, none, unknown are now treated as other mrow-like
  elements.
* maction and semantics are moved into a separate file and new tests
  added now that they are mrow-like elements with some hidden children.

[1] w3c/mathml#182
[2] w3c/mathml#183
--

wpt-commits: c38ae4ac2e0af285deb06f33c75e1699d0718942
wpt-pr: 22381

UltraBlame original commit: 8e8fe19364e1c1ddc7d7ce589aa2fd8d8e23572c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MathML Core Issues affecting the MathML Core specification MathML 4 Issues affecting the MathML 4 specification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fred-wang @NSoiffer