Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): modernize MouseEvent initialization #2930

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Conversation

NaokiHaba
Copy link
Contributor

@NaokiHaba NaokiHaba commented Mar 6, 2025

resolve #xxx

Description

Replaced deprecated initMouseEvent method with modern MouseEvent constructor for better compatibility and future-proofing

The initMouseEvent method has been officially deprecated in favor of the more modern MouseEvent constructor. This change:

References:

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit c24a17d
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/67c97dc70418b700084623e0
😎 Deploy Preview https://deploy-preview-2930--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Mar 6, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@pinia/nuxt@2930
npm i https://pkg.pr.new/pinia@2930
npm i https://pkg.pr.new/@pinia/testing@2930

commit: c24a17d

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.34%. Comparing base (3b21e08) to head (c24a17d).
Report is 9 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2930      +/-   ##
==========================================
+ Coverage   91.23%   91.34%   +0.10%     
==========================================
  Files          17       17              
  Lines        1381     1398      +17     
  Branches      211      211              
==========================================
+ Hits         1260     1277      +17     
  Misses        120      120              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NaokiHaba NaokiHaba marked this pull request as ready for review March 6, 2025 10:54
@NaokiHaba
Copy link
Contributor Author

Seems good to me!

Thank you! I appreciate your review. I'm glad to have your approval.

@posva posva merged commit 4b324cc into vuejs:v3 Mar 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants