AV-231513 HTTPRoute Rewrite Filter #1662
Conversation
pkoshtavmware
added
enhancement
pkoshtavmware
force-pushed
the
AV-231513-master
branch
from
fb4f04e to
dcf8deb
Compare
pkoshtavmware
added
open-for-review
pkoshtavmware
requested review from
arihantg,
akshayhavile,
ashishnayak96,
DixitAakash and
apalsule
| @@ -350,6 +350,13 @@ func (o *AviObjectGraph) BuildHTTPPolicySet(key string, vsNode *nodes.AviEvhVsNo | |||
| utils.AviLog.Infof("key: %s, msg: Attached HTTP redirect policy to vs %s", key, vsNode.Name) | |||
| return | |||
| } | |||
| isUrlRewritePresent := o.BuildHTTPPolicySetHTTPRequestUrlRewriteRules(key, httpPSName, vsNode, routeModel, rule.Filters, index) | |||
| if isUrlRewritePresent { | |||
There was a problem hiding this comment.
RequestHeader and ResposeHeader modifier add, remove, modify headers of request / response. URLRewriteFilter works on path and hostname. These filters seems to be compatible with each other. Do we want to skip processing those?
There was a problem hiding this comment.
It was an older code. Have updated the recent code without skipping
|
|
||
| func (o *AviObjectGraph) BuildHTTPPolicySetHTTPRequestUrlRewriteRules(key, httpPSname string, vsNode *nodes.AviEvhVsNode, routeModel RouteModel, filters []*Filter, index int) bool { | ||
| urlRewriteAction := &models.HTTPRewriteURLAction{} | ||
| isUrlRewritePresent := false |
There was a problem hiding this comment.
Nit: We can avoid this variable by returning true or false.
There was a problem hiding this comment.
Removed the variable altogether
pkoshtavmware
force-pushed
the
AV-231513-master
branch
3 times, most recently
from
fd4862d to
6490c68
Compare
There was a problem hiding this comment.
@pkoshtavmware Changes looks good to me.
We should add few test cases:
- Ingestion test case to validate urlRewrite (This will validate our Validation logic)
- GraphLayer test case/ FT test cases where we only mention one of the urlrewrite filter (hostname/path) and check what is the behaviour.
pkoshtavmware
force-pushed
the
AV-231513-master
branch
from
6490c68 to
5b64a6f
Compare
@akshayhavile Added unit testcases in ingestion graph and status layer. However, validation is added in the status layer since we have recently moved httproute validation to ingestion layer |
pkoshtavmware
force-pushed
the
AV-231513-master
branch
from
5b64a6f to
f56327a
Compare
|
build ako |
AV-231513 HTTPRoute Rewrite Filter