Don't build punica kernels by default #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should make sure CI builds it! let's set the env var there? |
|
Yes, I'm running the CI now, will see what fails and then fix it :) Also we need to make sure the final wheel is built with LoRA, do you know where that's built? |
|
|
|
Final wheels is here https://github.com/vllm-project/vllm/blob/main/.github/workflows/publish.yml |
|
@simon-mo Let me know what you think, I believe I put the environment variables at the right places (let's see if the tests agree) :) |
NikolaBorisov
pushed a commit
to deepinfra/vllm
that referenced
this pull request
Jan 31, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
alexm-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The punica kernels take quite a while to build and most developers won't need them, so it will be better to not build them by default.
Maybe in the future the build can be optimized and then we can bring them back. E.g. if we had good incremental compilation that would probably solve the problem.
Fixes #2604