fix: --https is invalid in preview

[y1d7ng]

Description

fix #4169
--https is invalid in vite preview.

>  vite preview --https

console:

> Local: http://localhost:5000/

The protocol of the url is http, and the url with https https://localhost:5000 cannot be opened.

Additional context

options.https is not passed into resolveConfig

vite/packages/vite/src/node/cli.ts

Lines 206 to 215 in decc7d8

	const config = await resolveConfig(
	{
	root,
	base: options.base,
	configFile: options.config,
	logLevel: options.logLevel,
	server: {
	open: options.open,
	strictPort: options.strictPort
	}

but subsequent execution depends on config.server.https

vite/packages/vite/src/node/preview.ts

Line 56 in decc7d8

const protocol = options.https ? 'https' : 'http'

vite/packages/vite/src/node/server/http.ts

Lines 32 to 35 in decc7d8

	export async function resolveHttpsConfig(
	config: ResolvedConfig
	): Promise<HttpsServerOptions | undefined> {
	if (!config.server.https) return undefined

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[Shinigami92]

I think this would be a feature request 🤔
But ... do we even want to support that or is it by design?
preview should not serve content for production but just to test if the build/dist works

[y1d7ng]

I think this would be a feature request 🤔
But ... do we even want to support that or is it by design?
preview should not serve content for production but just to test if the build/dist works

@Shinigami92 Sorry, maybe I didn't describe the pr clearly. The main solution of this pr is that the --https config option doesn't take effect when use preview. I think using https in preview is may not a feature according to the previous code.

vite/packages/vite/src/node/cli.ts

Line 191 in decc7d8

.option('--https', `[boolean] use TLS + HTTP/2`)

#4169 This issue reports two bugs, I think the serve root bug is due to incorrect usage. This pr solved the bug of https.

[husayt]

@patak-js @OneNail thanks, but this doesn't solve #4169 entirely.
Yes it solves --https parameter, but root is still not working with preview. I can't reopen the original card, since commenting here.

Thanks

[y1d7ng]

@patak-js @OneNail thanks, but this doesn't solve #4169 entirely.
Yes it solves --https parameter, but root is still not working with preview. I can't reopen the original card, since commenting here.

Thanks

The vite preview root you use, is the root an normal directory or a directory of vite project?

[husayt]

Normally preview uses dist folder, but I also have storybook-dist and sometimes want to run from that folder. Why to install another static server, when vite can do that.?

[y1d7ng]

Normally preview uses dist folder, but I also have storybook-dist and sometimes want to run from that folder. Why to install another static server, when vite can do that.?

According to the current design, root refers to your vite project, not the dist directory generated by build.

[husayt]

@OneNail if root setting doesn't work, then why is it there? If contents of my dist folder was in xyzdist and I would run vite preview xyzdist it still would not work. I might be trying to use if for different purpose, but the feature doesn't work to start with

[sasivarnan]

I also have the exact use case as @husayt. I am using lib mode of vite to build react component library.

I use vite builder for storybook - storybook-builder-vite.

And there isn't much to preview the contents of dist directory as it is a library. Ability to preview stroybook-static folder after building it would be super helpful.

[y1d7ng]

@OneNail if root setting doesn't work, then why is it there? If contents of my dist folder was in xyzdist and I would run vite preview xyzdist it still would not work. I might be trying to use if for different purpose, but the feature doesn't work to start with

The root setting can work. If the name of the vite project is xyzdist, you can preview by executing vite preview xyzdist outside this directory.

[y1d7ng]

I also have the exact use case as @husayt. I am using lib mode of vite to build react component library.

I use vite builder for storybook - storybook-builder-vite.

And there isn't much to preview the contents of dist directory as it is a library. Ability to preview stroybook-static folder after building it would be super helpful.

You can consider opening a pr or issue for this feature.