Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rebuild asset for watch mode(fix #3271) #3480

Closed
wants to merge 1 commit into from
Closed

fix: rebuild asset for watch mode(fix #3271) #3480

wants to merge 1 commit into from

Conversation

CHOYSEN
Copy link
Contributor

@CHOYSEN CHOYSEN commented May 20, 2021

Description

Fix #3271

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 20, 2021
@Shinigami92 Shinigami92 requested review from patak-dev and antfu May 20, 2021 08:26
@patak-dev
Copy link
Member

Thanks for the PR @CHOYSEN and your guide to resolve this issue, I think we should ensure that the caches are regenerated for each build instead of ignoring them. I sent an alternative PR here #3512, as I needed to check that this approach will work correctly.

@patak-dev patak-dev closed this May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does't coped fonts in build --watch mode
3 participants