Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transform json in deep import #1459

Merged
merged 7 commits into from
Jan 10, 2021
Merged

Conversation

hannoeru
Copy link
Contributor

@hannoeru hannoeru commented Jan 9, 2021

fix: #1458

@hannoeru hannoeru marked this pull request as ready for review January 9, 2021 14:50
@yyx990803
Copy link
Member

The test actually won't be testing the original bug because Vite only appends the version hash when the dep is in node_modules (this is to avoid caching locally linked packages which are likely to be source instead of actual deps)

@yyx990803
Copy link
Member

I think the easy way to test it is simply adding an import to a non-optimized dep, e.g. @vue/runtime-core/package.json in the json playground.

@yyx990803 yyx990803 merged commit cf8342b into vitejs:main Jan 10, 2021
@hannoeru hannoeru deleted the fix/transform-json branch February 4, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep import json file will not be transform to ES6 modules
2 participants