Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lint for typescript for script tag without type module #5837

Closed
4 tasks done
userquin opened this issue Nov 25, 2021 · 1 comment · Fixed by #5838
Closed
4 tasks done

add lint for typescript for script tag without type module #5837

userquin opened this issue Nov 25, 2021 · 1 comment · Fixed by #5838

Comments

@userquin
Copy link
Contributor

Clear and concise description of the problem

Since it is valid to use js file from public directory on index.html we can add some linting to warn the user when using a typescript module on the script without type module.

Suggested solution

Modify buildHtmlPlugin in src/node/plugins/html.ts to warn the user using config.logger.warn

Alternative

No response

Additional context

This enhancement comes from this entry on discord with Alec Parson: https://discord.com/channels/804011606160703521/814182556068085760/913493338404028487

Validations

@aleclarson
Copy link
Member

Thanks Joaquin!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants