Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the need for "processSourceMap" #18187

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Sep 24, 2024

Description

This PR move the logic that fixes the source maps in the module runner to the evaluator.

The evaluator is the reason why we need this change, so it makes sense that it will the one controlling it.

Copy link

stackblitz bot commented Sep 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-dev
patak-dev previously approved these changes Sep 24, 2024
@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 288fc64: Open

suite result latest scheduled
histoire failure failure
redwoodjs failure success
remix failure failure
vike failure failure
vite-environment-examples failure success

analogjs, astro, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, storybook, sveltekit, unocss, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest, vuepress

@patak-dev
Copy link
Member

/ecosystem-ci run

@patak-dev patak-dev merged commit 08ff233 into vitejs:main Sep 24, 2024
12 checks passed
@sheremet-va sheremet-va deleted the refactor/move-offset-to-evaluator branch September 24, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants