Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test module runner stacktrace on browser #117

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Sep 28, 2024

It's not working on 6.0.0-beta.1, but works on current main. Is this related?

Error stack in devtool

image


I see. Currently, we are actually using createNodeDevEnvironment, which is mostly working but it was adding source map offset. vitejs/vite#18187 removed it, so now source map is working on browser side.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on Graphite Graphite

@hi-ogawa hi-ogawa marked this pull request as ready for review September 28, 2024 06:15
@hi-ogawa hi-ogawa merged commit ee977ed into main Sep 28, 2024
1 check passed
@hi-ogawa hi-ogawa deleted the test-worker-runner-error-stack branch September 28, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant