fix(ssr): ssr transform method definition (#2223)

vitejs · Feb 26, 2021 · 8e0c0fa · 8e0c0fa
1 parent 1342108
commit 8e0c0fa
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts b/packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts
@@ -121,6 +121,20 @@ test('import.meta', async () => {
   ).toMatchInlineSnapshot(`"console.log(__vite_ssr_import_meta__.url)"`)
 })
 
+test('do not rewrite method definition', async () => {
+  expect(
+    (
+      await ssrTransform(
+        `import { fn } from 'vue';class A { fn() { fn() } }`,
+        null
+      )
+    ).code
+  ).toMatchInlineSnapshot(`
+    "const __vite_ssr_import_0__ = __vite_ssr_import__(\\"vue\\")
+    class A { fn() { __vite_ssr_import_0__.fn() } }"
+  `)
+})
+
 test('dynamic import', async () => {
   expect(
     (await ssrTransform(`export const i = () => import('./foo')`, null)).code

diff --git a/packages/vite/src/node/ssr/ssrTransform.ts b/packages/vite/src/node/ssr/ssrTransform.ts
@@ -302,6 +302,11 @@ function isRefIdentifier(id: Identifier, parent: _Node, parentStack: _Node[]) {
       return false
     }
   }
+
+  // class method name
+  if (parent.type === 'MethodDefinition') {
+    return false
+  }
 
   // property key
   // this also covers object destructure pattern