fix: more inclusive config syntax error hanlding for Node 12.x

close #2050
vitejs · Feb 17, 2021 · 27785f7 · 27785f7
1 parent ab8a55e
commit 27785f7
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts
@@ -678,9 +678,11 @@ export async function loadConfigFromFile(
         const ignored = new RegExp(
           [
             `Cannot use import statement`,
-            `Unexpected token 'export'`,
             `Must use import to load ES Module`,
-            `Unexpected identifier` // #1635 Node <= 12.4 has no esm detection
+            // #1635, #2050 some Node 12.x versions don't have esm detection
+            // so it throws normal syntax errors when encountering esm syntax
+            `Unexpected token`,
+            `Unexpected identifier`
           ].join('|')
         )
         if (!ignored.test(e.message)) {