-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min/max zoom support #629
Closed
Closed
Changes from 11 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
09f05d9
feat(interaction): add zoom min/max support
gregdeane aaec879
Merge pull request #1 from gregdeane/zoom
gregdeane 6403939
Merge branch 'master' into master
gregdeane 1e5474c
fix tests
gregdeane da83b65
Merge pull request #2 from gregdeane/zoom-test-fixes
gregdeane 43762ff
fix lint
gregdeane ecd7571
Merge pull request #3 from gregdeane/zoom-test-fixes
gregdeane b7c9cba
Merge remote-tracking branch 'upstream/master'
gregdeane 1b38b3a
Merge branch 'master' of github.com:gregdeane/vis-network
gregdeane 33eba3c
update per pr comments
gregdeane 132ffc1
Merge pull request #4 from gregdeane/zoom-pr-comments
gregdeane d08ca90
Merge remote-tracking branch 'upstream/master'
gregdeane 185fe1e
update per pr comments pt 2
gregdeane 08cd2a1
Merge pull request #5 from gregdeane/zoom-pr-comments-pt-2
gregdeane a10bb78
Merge branch 'master' into master
gregdeane 69a30b0
Merge remote-tracking branch 'upstream/master'
gregdeane 75cef98
Merge branch 'master' of github.com:gregdeane/vis-network
gregdeane 7e11e23
update per pr comments pt 2
gregdeane bbc8fd9
Merge pull request #6 from gregdeane/zoom-pr-comments-pt-2
gregdeane d9f5ccb
update per pr comments pt 2
gregdeane dc97c06
Merge pull request #7 from gregdeane/zoom-pr-comments-pt-2
gregdeane 3783fba
Merge remote-tracking branch 'upstream/master'
gregdeane 6169db2
Merge branch 'master' into zoom-pr-comments-pt-2
gregdeane c627d0e
update per pr comments pt 2
gregdeane e7da897
Merge pull request #8 from gregdeane/zoom-pr-comments-pt-2
gregdeane 7840be1
Merge branch 'master' into master
gregdeane aa430d3
Merge branch 'master' into master
gregdeane f22a052
Merge remote-tracking branch 'upstream/master'
gregdeane aabd178
Merge branch 'master' into zoom-pr-comments-pt-2
gregdeane b372d01
Merge branch 'master' of github.com:gregdeane/vis-network
gregdeane 849d219
Merge remote-tracking branch 'upstream/master'
gregdeane f98ba86
Merge branch 'master' into zoom-pr-comments-pt-2
gregdeane baed5ae
Merge branch 'master' into master
gregdeane f076795
update per pr comments pt 2
gregdeane 077dee4
Merge branch 'master' of github.com:gregdeane/vis-network
gregdeane 8d00e3e
Merge branch 'master' into zoom-pr-comments-pt-2
gregdeane cc70aaf
Merge pull request #9 from gregdeane/zoom-pr-comments-pt-2
gregdeane 56ea7f9
Merge remote-tracking branch 'upstream/master'
gregdeane 0b15916
Merge branch 'master' into zoom-pr-comments-pt-2
gregdeane 65ffe9a
update per pr comments pt 2
gregdeane f0692f0
Merge pull request #10 from gregdeane/zoom-pr-comments-pt-2
gregdeane d7a1078
Merge branch 'master' into master
gregdeane 5050b56
Merge branch 'master' into master
gregdeane 2a9c866
Merge branch 'master' into master
gregdeane aa9862c
Merge branch 'master' into master
gregdeane a5bb3e3
Merge remote-tracking branch 'upstream/master'
gregdeane 3961eb6
Merge branch 'master' into master
gregdeane a20c289
Merge branch 'master' into master
gregdeane 12a9ca0
Merge branch 'master' into master
gregdeane ee152c2
Merge remote-tracking branch 'upstream/master'
gregdeane bbc9f33
0.0.0
gregdeane 940abbc
1.0.0
gregdeane cac0927
update package version
gregdeane d5affa1
update package lock
gregdeane b1b7e73
update name
gregdeane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get this. Why is the range so small?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly because min/max are separate props. What I mean is: Since there is a
min
prop, I thought it would be strange to put a very low number in themax
prop.I'm happy to put the range you think is appropriate. What's your suggestion for both props?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go with 0 through 10 for both. The input validation should handle cases where max is smaller than min etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, thank you.