Add support for Google Gemini models #92
Open
+867
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virattt
reviewed
Feb 10, 2025
| @@ -336,6 +337,13 @@ def analyze_valuation(financial_line_items: list, market_cap: float) -> dict: | |||
| } | |||
|
|
|||
|
|
|||
| def create_default_bill_ackman_signal(): | |||
There was a problem hiding this comment.
Do we need to extract this into a public function?
virattt
reviewed
Feb 10, 2025
|
|
||
| T = TypeVar('T', bound=BaseModel) | ||
|
|
||
| def get_llm(provider: str, model_name: str): |
|
I like the idea of adding the Gemini models and am supportive! However, this PR is doing more than just adding support for models. Can we scope this PR more tightly so it only adds the Gemini models and doesn't make any of the unrelated changes? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the Google Gemini Series of models as they lead in the benchmarks for complex tasks.