Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow install flask 3.0.0 #236

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

ssimk0
Copy link
Contributor

@ssimk0 ssimk0 commented Nov 6, 2023

I tested the apscheduler with flask version 3.0.0 all tests pass also my app is working with this. I think is should be safe allow install it also with flask 3.0.0

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e29d542) 91.82% compared to head (6b1a104) 91.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files           6        6           
  Lines         428      428           
=======================================
  Hits          393      393           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viniciuschiele
Copy link
Owner

Thanks for the PR, can you also change the Flask version in the file setup.py?

@ssimk0
Copy link
Contributor Author

ssimk0 commented Nov 6, 2023

sure, take me minute to do that :)

@viniciuschiele
Copy link
Owner

viniciuschiele commented Nov 6, 2023

I will release a new version later today.

Related to #235

@viniciuschiele viniciuschiele merged commit 5a96198 into viniciuschiele:master Nov 7, 2023
@viniciuschiele
Copy link
Owner

Version 1.31.1 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants