Skip to content

Commit

Permalink
Return NSString instead of SEL
Browse files Browse the repository at this point in the history 
Reviewed By: javache

Differential Revision: D6211964

fbshipit-source-id: 4a55d56d0cc4be10460087810f62134676983203
  • Loading branch information
@aditya7fb @facebook-github-bot
aditya7fb authored and facebook-github-bot committed Nov 3, 2017
1 parent a8e2cce commit 0958abe
Showing 1 changed file with 31 additions and 31 deletions.
62 changes: 31 additions & 31 deletions RNTesterUnitTests/RCTMethodArgumentTests.m
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@ @interface RCTMethodArgumentTests : XCTestCase

@implementation RCTMethodArgumentTests

extern SEL RCTParseMethodSignature(const char *methodSignature, NSArray **argTypes);
extern NSString *RCTParseMethodSignature(const char *methodSignature, NSArray **argTypes);

- (void)testOneArgument
{
NSArray *arguments;
const char *methodSignature = "foo:(NSInteger)foo";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:");
XCTAssertEqual(arguments.count, (NSUInteger)1);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSInteger");
}
Expand All @@ -35,8 +35,8 @@ - (void)testTwoArguments
{
NSArray *arguments;
const char *methodSignature = "foo:(NSInteger)foo bar:(BOOL)bar";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:bar:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:bar:");
XCTAssertEqual(arguments.count, (NSUInteger)2);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSInteger");
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[1]).type, @"BOOL");
Expand All @@ -46,8 +46,8 @@ - (void)testSpaces
{
NSArray *arguments;
const char *methodSignature = "foo : (NSInteger)foo bar : (BOOL) bar";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:bar:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:bar:");
XCTAssertEqual(arguments.count, (NSUInteger)2);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSInteger");
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[1]).type, @"BOOL");
Expand All @@ -57,8 +57,8 @@ - (void)testNewlines
{
NSArray *arguments;
const char *methodSignature = "foo : (NSInteger)foo\nbar : (BOOL) bar";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:bar:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:bar:");
XCTAssertEqual(arguments.count, (NSUInteger)2);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSInteger");
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[1]).type, @"BOOL");
Expand All @@ -68,8 +68,8 @@ - (void)testUnnamedArgs
{
NSArray *arguments;
const char *methodSignature = "foo:(NSInteger)foo:(BOOL)bar";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo::");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo::");
XCTAssertEqual(arguments.count, (NSUInteger)2);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSInteger");
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[1]).type, @"BOOL");
Expand All @@ -79,8 +79,8 @@ - (void)testUntypedUnnamedArgs
{
NSArray *arguments;
const char *methodSignature = "foo:foo:bar:bar";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:::");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:::");
XCTAssertEqual(arguments.count, (NSUInteger)3);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"id");
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[1]).type, @"id");
Expand All @@ -91,8 +91,8 @@ - (void)testNamespacedCxxStruct
{
NSArray *arguments;
const char *methodSignature = "foo:(foo::type &)foo bar:(bar::type &)bar";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:bar:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:bar:");
XCTAssertEqual(arguments.count, (NSUInteger)2);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"foo::type");
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[1]).type, @"bar::type");
Expand All @@ -102,8 +102,8 @@ - (void)testAttributes
{
NSArray *arguments;
const char *methodSignature = "foo:(__attribute__((unused)) NSString *)foo bar:(__unused BOOL)bar";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:bar:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:bar:");
XCTAssertEqual(arguments.count, (NSUInteger)2);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSString");
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[1]).type, @"BOOL");
Expand All @@ -113,8 +113,8 @@ - (void)testNullability
{
NSArray *arguments;
const char *methodSignature = "foo:(nullable NSString *)foo bar:(nonnull NSNumber *)bar baz:(id)baz";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:bar:baz:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:bar:baz:");
XCTAssertEqual(arguments.count, (NSUInteger)3);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSString");
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[1]).type, @"NSNumber");
Expand All @@ -128,8 +128,8 @@ - (void)testSemicolonStripping
{
NSArray *arguments;
const char *methodSignature = "foo:(NSString *)foo bar:(BOOL)bar;";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:bar:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:bar:");
XCTAssertEqual(arguments.count, (NSUInteger)2);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSString");
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[1]).type, @"BOOL");
Expand All @@ -139,8 +139,8 @@ - (void)testUnused
{
NSArray *arguments;
const char *methodSignature = "foo:(__unused NSString *)foo bar:(NSNumber *)bar";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:bar:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:bar:");
XCTAssertEqual(arguments.count, (NSUInteger)2);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSString");
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[1]).type, @"NSNumber");
Expand All @@ -152,8 +152,8 @@ - (void)testGenericArray
{
NSArray *arguments;
const char *methodSignature = "foo:(NSArray<NSString *> *)foo;";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:");
XCTAssertEqual(arguments.count, (NSUInteger)1);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSStringArray");
}
Expand All @@ -162,8 +162,8 @@ - (void)testNestedGenericArray
{
NSArray *arguments;
const char *methodSignature = "foo:(NSArray<NSArray<NSString *> *> *)foo;";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:");
XCTAssertEqual(arguments.count, (NSUInteger)1);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSStringArrayArray");
}
Expand All @@ -172,8 +172,8 @@ - (void)testGenericSet
{
NSArray *arguments;
const char *methodSignature = "foo:(NSSet<NSNumber *> *)foo;";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:");
XCTAssertEqual(arguments.count, (NSUInteger)1);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSNumberSet");
}
Expand All @@ -182,8 +182,8 @@ - (void)testGenericDictionary
{
NSArray *arguments;
const char *methodSignature = "foo:(NSDictionary<NSString *, NSNumber *> *)foo;";
SEL selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(NSStringFromSelector(selector), @"foo:");
NSString *selector = RCTParseMethodSignature(methodSignature, &arguments);
XCTAssertEqualObjects(selector, @"foo:");
XCTAssertEqual(arguments.count, (NSUInteger)1);
XCTAssertEqualObjects(((RCTMethodArgument *)arguments[0]).type, @"NSNumberDictionary");
}
Expand Down

0 comments on commit 0958abe

Please sign in to comment.