Use "&mut self" in methods writing to Database #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch only modifies the methods modifying
Database
object, making them take&mut self
as a parameter. This prevents the situation described in #48, where it's possible to have both a read-only reference and a writable reference to the same element.I've fixed the compilation of the tests - it can be seen that the API changes introduced here are minimal.
The following functions were modified:
Database::set
Database::append
Database::append_duplicate
Database::insert
Database::del
Database::del_item
Database::clear
Anyway, thanks for making the crate. It's really useful!