Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the license to upload to crates.io. #3

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Apr 20, 2021

See rust-lang/cargo#2174 (comment) for crates.io now try check the license by spdx, and spdx not introduce the common clause in spdx/license-list-XML#902

@Shylock-Hg Shylock-Hg requested a review from laura-ding April 20, 2021 07:38
@darionyaphet
Copy link

Is it need to be consistent with the main repo ?

@Shylock-Hg
Copy link
Contributor Author

Is it need to be consistent with the main repo ?

In my think, the client don't need the cc license. CC is used to prevent SasS provider, the client has no this issue.

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2021

CLA assistant check
All committers have signed the CLA.

@visortelle
Copy link

Any news on this PR?

@Shylock-Hg
Copy link
Contributor Author

Any news on this PR?

Our reviewer don't agree to.

@visortelle
Copy link

visortelle commented Aug 24, 2021

But you need to make some decision on it anyway. 🙂

I'll provide some options I found:

SPDX LienseRef with a custom license

Consider SPDX LicenseRef.

This section is used for any detected, declared, or concluded licenses that are NOT on the SPDX License List.

It will look something like LicenseRef-Nebula-Graph-1.0.

Additionally use license-file Cargo.toml field.

Server Side Public License (SSPL) v1

MongoDB and Elasticsearch use this license.

It's a valid SPDX license: https://spdx.org/licenses/SSPL-1.0.html

https://github.com/elastic/elasticsearch/blob/master/LICENSE.txt

https://github.com/mongodb/mongo/blob/master/LICENSE-Community.txt

Business Source License 1.1 (BSL)

https://github.com/cockroachdb/cockroach/blob/master/LICENSE

It's a valid SPDX license: https://spdx.org/licenses/BUSL-1.1.html


As both mentioned licenses are valid SPDX licenses, you should be able to combine any of them with Apache-2.0 as it has done here: https://github.com/kubo/rust-oracle/blob/7832f993c207904dcca0186f3fb8cac75404c508/Cargo.toml#L7


I also don't see any sense in the proprietary license for the database client code. @laura-ding did you ever saw such examples? Maybe I'm missing something.

Thank you.

@Shylock-Hg
Copy link
Contributor Author

But you need to make some decision on it anyway. 🙂

I'll provide some options I found:

SPDX LienseRef with a custom license

Consider SPDX LicenseRef.

This section is used for any detected, declared, or concluded licenses that are NOT on the SPDX License List.

It will look something like LicenseRef-Nebula-Graph-1.0.

Additionally use license-file Cargo.toml field.

Server Side Public License (SSPL) v1

MongoDB and Elasticsearch use this license.

It's a valid SPDX license: https://spdx.org/licenses/SSPL-1.0.html

https://github.com/elastic/elasticsearch/blob/master/LICENSE.txt

https://github.com/mongodb/mongo/blob/master/LICENSE-Community.txt

Business Source License 1.1 (BSL)

https://github.com/cockroachdb/cockroach/blob/master/LICENSE

It's a valid SPDX license: https://spdx.org/licenses/BUSL-1.1.html

As both mentioned licenses are valid SPDX licenses, you should be able to combine any of them with Apache-2.0 as it has done here: https://github.com/kubo/rust-oracle/blob/7832f993c207904dcca0186f3fb8cac75404c508/Cargo.toml#L7

I also don't see any sense in the proprietary license for the database client code. @laura-ding did you ever saw such examples? Maybe I'm missing something.

Thank you.

Yes, thanks for suggestion. My member prefer to let user include the source directly instead of add as library. And I will try to push this PR before this client release.

@wey-gu
Copy link

wey-gu commented Jan 16, 2022

@Shylock-Hg as we changed to apache 2.0(removing cc), thus it's good to go with SPDX, right? :D

@Shylock-Hg
Copy link
Contributor Author

@Shylock-Hg as we changed to apache 2.0(removing cc), thus it's good to go with SPDX, right? :D

Yes

@Sophie-Xie
Copy link

Too long, close it.

@Sophie-Xie Sophie-Xie closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants