Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX - Plugins config loader #1023

Merged
merged 2 commits into from
Apr 9, 2019
Merged

FIX - Plugins config loader #1023

merged 2 commits into from
Apr 9, 2019

Conversation

carlwilson
Copy link
Contributor

  • improved warnings when config loading fails.

contributes to #949

@carlwilson
FIX - Plugins config loader
1d1ca66 
- improved warnings when config loading fails.
@carlwilson carlwilson requested a review from BezrukovM April 9, 2019 01:23
@carlwilson carlwilson self-assigned this Apr 9, 2019
@carlwilson carlwilson added bug A product defect that needs fixing P2 Medium priority issues to be scheduled in a future release labels Apr 9, 2019
@carlwilson carlwilson added this to the v1.14-m2 milestone Apr 9, 2019
@codecov
Copy link

codecov bot commented Apr 9, 2019 •
edited
Loading

Codecov Report

Merging #1023 into integration will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration    #1023      +/-   ##
=================================================
- Coverage          26.52%   26.51%   -0.02%     
  Complexity           944      944              
=================================================
  Files                183      183              
  Lines               7445     7449       +4     
  Branches            1118     1119       +1     
=================================================
  Hits                1975     1975              
- Misses              5206     5210       +4     
  Partials             264      264
Impacted Files Coverage Δ Complexity Δ
...a/org/verapdf/processor/FeaturesPluginsLoader.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb1d791...068b803. Read the comment docs.

@carlwilson carlwilson merged commit 2f6e07f into integration Apr 9, 2019
@carlwilson carlwilson deleted the fix/plugins-config-949 branch April 9, 2019 15:11
@carlwilson carlwilson mentioned this pull request Apr 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BezrukovM BezrukovM BezrukovM approved these changes

Assignees

@carlwilson carlwilson

Labels
bug A product defect that needs fixing P2 Medium priority issues to be scheduled in a future release
Projects
None yet
Milestone
v1.14-m2
Development

Successfully merging this pull request may close these issues.
2 participants
@carlwilson @BezrukovM