feat: quic #1265
Open
feat: quic #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
force-pushed
the
tls
branch
14 times, most recently
from
c1294d4 to
8d7e551
Compare
richard-ramos
force-pushed
the
tls-quic
branch
5 times, most recently
from
18e5b7f to
55c664a
Compare
|
Looks like there are some issues with building mbed-tls in windows, macos(arm64) and linux(i386). |
vladopajic
approved these changes
Mar 6, 2025
|
|
||
| let keypair = KeyPair(seckey: self.privateKey, pubkey: pubkey) | ||
|
|
||
| let certPair = generate(keypair, EncodingFormat.PEM) |
There was a problem hiding this comment.
-
generatewhat? it's deductible from context that certificate is created but better naming would be appreciated. eg.certificate.generateorgenerateCertificate... -
also
generatereturns tuple, but why not named tuple? or why not simple type? usage likecertPair[0],certPair[1]is not really readable and understandable unless you go into the function.
i know it's not related to this pr, but if you agree we can create issue for this, ideal for "good first issues" lable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables quic transport with a proper TLS backend, and tests connection and comms between two nodes. There are still some pending items like dealing with port
0in multiaddresses, as well as well as ensuring that connections/streams lifetime is handled correctly. This is to be done in upcoming PRsDo note that one of the commits changes the
not implementedassertion to something that gives a bit more context, so it's easier to know which abstract method a dev forgot to implement.