feat: use single scanner for plugin class scan #21104
Open
+167
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
reviewed
Mar 10, 2025
...erver/src/main/java/com/vaadin/flow/server/frontend/scanner/FrontendDependenciesScanner.java
Show resolved
Hide resolved
| @@ -366,7 +368,7 @@ public static void runNodeUpdater(PluginAdapterBuild adapter) | |||
| adapter.frontendExtraFileExtensions()) | |||
| .withFrontendIgnoreVersionChecks( | |||
| adapter.isFrontendIgnoreVersionChecks()); | |||
| new NodeTasks(options).execute(); | |||
| new NodeTasks(options, frontendDependencies).execute(); | |||
There was a problem hiding this comment.
Perhaps it would be cleaner/clearer to add the frontendDependencies to options and use options.getFrontendScanner() which would then init it if not given.
caalador
reviewed
Mar 10, 2025
| @@ -96,20 +96,30 @@ public class NodeTasks implements FallibleCommand { | |||
|
|
|||
| private Path lockFile; | |||
|
|
|||
| public NodeTasks(Options options) { | |||
| this(options, | |||
There was a problem hiding this comment.
This scanner builder doesn't check the router required.
boolean reactEnabled = options.isReactEnabled() && FrontendUtils.isReactRouterRequired(options.getFrontendDirectory());
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21016