Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts upgrade gas estimate fix #7548

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Contracts upgrade gas estimate fix #7548

merged 3 commits into from
Sep 13, 2021

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Sep 13, 2021

Description

Update failing tests after contracts upgrade in #6870

Issues

Fixes #6870
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@cla-bot cla-bot bot added the cla-signed label Sep 13, 2021
@clemsos clemsos requested a review from julien51 September 13, 2021 11:37
@clemsos
Copy link
Member Author

clemsos commented Sep 13, 2021

The current fix seems to work but maybe there is a better way to estimate gas costs?

@julien51 julien51 merged commit 91456d9 into master Sep 13, 2021
@julien51 julien51 deleted the contracts-upgrade-gas-estimate-fix branch September 13, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien51 julien51 Awaiting requested review from julien51

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clemsos @julien51 @renovate-bot