Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement base64url in buffer by switching to js-base64 #471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huseeiin
Copy link

fixes #462

@huseeiin huseeiin requested a review from pi0 as a code owner February 24, 2025 15:23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you refactor this to .ts for better type checking?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a .d.ts, so you already get type checking when you import it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i understand but most of other codebase is using ts (types inlined)

@pi0
Copy link
Member

pi0 commented Mar 8, 2025

@huseeiin any specific reason you haven't gone with Deno stdlib implementation as your original idea? checking, it seems this lib has extra polyfills for legacy env without atob support which we probably don't need that concern here.

@huseeiin
Copy link
Author

huseeiin commented Mar 9, 2025

@huseeiin any specific reason you haven't gone with Deno stdlib implementation as your original idea? checking, it seems this lib has extra polyfills for legacy env without atob support which we probably don't need that concern here.

i will use the deno stdlib version if you want, i support that idea too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement base64url in Buffer
2 participants