Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix semantic expression of BLS cryptography #3927

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wonderfan
Copy link

The expression of BLS signatures and verifications is wrong and make them correct.

Copy link

vercel bot commented Mar 4, 2025

@wonderfan is attempting to deploy a commit to the unionbuild Team on Vercel.

A member of the Team first needs to authorize it.

@benluelo
Copy link
Contributor

benluelo commented Mar 4, 2025

Hi, thanks for the PR! Please remove the merge commit and rebase your branch on main instead. See our CONTRIBUTING.md for all PR requirements.

@wonderfan
Copy link
Author

Hi, thanks for the PR! Please remove the merge commit and rebase your branch on main instead. See our CONTRIBUTING.md for all PR requirements.

@benluelo Thanks for your kind remind. The change set are rebased and force pushed. Please take a look.

@benluelo
Copy link
Contributor

benluelo commented Mar 4, 2025

hey @wonderfan, you will also need to sign your commits

@wonderfan
Copy link
Author

hey @wonderfan, you will also need to sign your commits

How to sign?

@benluelo
Copy link
Contributor

benluelo commented Mar 4, 2025

hey @wonderfan, you will also need to sign your commits

How to sign?

This is described in our CONTRIBUTING.md: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@wonderfan wonderfan force-pushed the develop branch 2 times, most recently from b1003e4 to f4d98e7 Compare March 4, 2025 23:26
@wonderfan
Copy link
Author

hey @wonderfan, you will also need to sign your commits

How to sign?

This is described in our CONTRIBUTING.md: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@benluelo Thanks for your helpful instruction. The code snippets are signed. Please take a look again.

@wonderfan wonderfan requested a review from aeryz March 4, 2025 23:33
@wonderfan
Copy link
Author

@aeryz @benluelo The failed checks have this error:

✘ [ERROR] In a non-interactive environment, it's necessary to set a CLOUDFLARE_API_TOKEN environment variable for wrangler to work. Please go to https://developers.cloudflare.com/fundamentals/api/get-started/create-token/ for instructions on how to create an api token, and assign its value to CLOUDFLARE_API_TOKEN.


🪵  Logs were written to "/home/runner/.config/.wrangler/logs/wrangler-2025-03-04_23-57-07_[19](https://github.com/unionlabs/union/actions/runs/13665011583/job/38205187647?pr=3927#step:5:20)3.log"
Error: Process completed with exit code 1.

@wonderfan
Copy link
Author

CLOUDFLARE_API_TOKEN should be set in the environment variable.

@wonderfan wonderfan requested a review from benluelo March 5, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants