Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): wallet fix #2071

Merged
merged 4 commits into from
Jun 8, 2024
Merged

fix(app): wallet fix #2071

merged 4 commits into from
Jun 8, 2024

Conversation

Swepool
Copy link
Contributor

@Swepool Swepool commented Jun 8, 2024

Update $cosmosStore so we don't have old wallet values.

@Swepool Swepool requested a review from o-az June 8, 2024 16:37
Copy link

github-actions bot commented Jun 8, 2024

App 🤌

🌎 Deploying...
✨ Deployment complete! Take a peek over at https://62c1d810.app-1b1.pages.dev


@Swepool Swepool force-pushed the remove-wallet-#2065 branch from 7dac1e9 to 0b05aa1 Compare June 8, 2024 16:48
@Swepool Swepool changed the title Wallet fix for #2065 Fix: Wallet fix for #2065 Jun 8, 2024
@Swepool Swepool changed the title Fix: Wallet fix for #2065 fix(app): wallet fix Jun 8, 2024
@cor cor force-pushed the remove-wallet-#2065 branch from 0b05aa1 to 2f4012f Compare June 8, 2024 19:29
@cor cor temporarily deployed to app-preview June 8, 2024 19:31 — with GitHub Actions Inactive
@cor
Copy link
Contributor

cor commented Jun 8, 2024

Screenshot 2024-06-08 at 22 03 50 @Swepool seems to be partially working, the wallet is removed as is reflected in the background, but its still selected on the site and we can't dismiss the sidebar

Copy link
Contributor

@cor cor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

@Swepool
Copy link
Contributor Author

Swepool commented Jun 8, 2024

see my comment

How can I reproduce, is it a special order?

@Swepool
Copy link
Contributor Author

Swepool commented Jun 8, 2024

see my comment

How can I reproduce, is it a special order?

Ah I see it now, removing the address breaks another component. I'll fix.

Copy link
Contributor Author

@Swepool Swepool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as intended, another component on page / breaks due to no value.

@cor
Copy link
Contributor

cor commented Jun 8, 2024

Works great! I'm formatting for you (nix run .#pre-commit)

@cor cor force-pushed the remove-wallet-#2065 branch from f14cb3f to 8f16798 Compare June 8, 2024 22:23
@cor cor temporarily deployed to app-preview June 8, 2024 22:26 — with GitHub Actions Inactive
@cor cor merged commit f7122b3 into main Jun 8, 2024
36 checks passed
@cor cor deleted the remove-wallet-#2065 branch June 8, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants