Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): wallet fix #2055

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix(app): wallet fix #2055

merged 2 commits into from
Jun 7, 2024

Conversation

Swepool
Copy link
Contributor

@Swepool Swepool commented Jun 6, 2024

Changes

  • Added chaininfo for leap & keplr
  • Adjusted cosmosStore.connect to add chain and handle error/rejections

Docs for wallets in regards to this change.

@Swepool Swepool requested a review from o-az June 6, 2024 23:33
Copy link

github-actions bot commented Jun 6, 2024

App 🤌

🌎 Deploying...
✨ Deployment complete! Take a peek over at https://02b3ea37.app-1b1.pages.dev


o-az
o-az previously approved these changes Jun 7, 2024
Copy link
Contributor

@o-az o-az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Swepool. Tested this in a setup without union chain initially added and it worked

I'm approving this so feel free to merge

Note:

Please run format and lint in next prs

You can install editor extension to make it easier: https://biomejs.dev/guides/integrate-in-editor/

@o-az o-az self-requested a review June 7, 2024 08:56
@o-az o-az temporarily deployed to app-preview June 7, 2024 08:58 — with GitHub Actions Inactive
@o-az o-az merged commit 5bbd717 into main Jun 7, 2024
36 checks passed
@o-az o-az deleted the wallet-fixs branch June 7, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants