Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable-child-interaction going over edges + other details #251

Merged
merged 3 commits into from
Jun 28, 2022
+29 −5
Merged

fix: disable-child-interaction going over edges + other details #251

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac09463
fix disable-child-interaction going over edges
nielslyngsoe Jun 28, 2022
46fd23e
only show oultine when using keyboard navigation
nielslyngsoe Jun 28, 2022
7dabc5c
use new color system
nielslyngsoe Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/uui-css/lib/uui-text.css
View file
Original file line number Diff line number Diff line change
@@ -104,10 +104,10 @@

.uui-text a:link,
.uui-text a:active {
color: var(--uui-color-space-cadet);
color: var(--uui-color-interactive);
}
.uui-text a:hover {
color: var(--uui-color-violet-blue);
color: var(--uui-color-interactive-emphasis);
}

.uui-text small {
1 change: 1 addition & 0 deletions packages/uui-table/lib/uui-table-cell.element.ts
View file
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@ export class UUITableCellElement extends LitElement {
static styles = [
css`
:host {
position: relative;
display: table-cell;
height: var(--uui-table-cell-height, var(--uui-size-12));
padding: var(
29 changes: 26 additions & 3 deletions packages/uui-table/lib/uui-table-row.element.ts
View file
Original file line number Diff line number Diff line change
@@ -23,24 +23,47 @@ export class UUITableRowElement extends SelectOnlyMixin(
:host {
display: table-row;
position: relative;
outline-offset: -3px;
}

:host([selectable]) {
cursor: pointer;
}

:host(:focus) {
outline: calc(2px * var(--uui-show-focus-outline, 1)) solid
var(--uui-color-focus);
}
:host([selected]) {
outline: 2px solid
var(--uui-table-row-color-selected, var(--uui-color-selected));
outline-offset: -3px;
}

:host(:focus) {
:host([selected]:focus) {
outline-color: var(--uui-color-focus);
}
`,
];

constructor() {
super();

// hide outline if mouse-interaction:
let hadMouseDown = false;
this.addEventListener('blur', () => {
if (hadMouseDown === false) {
this.style.setProperty('--uui-show-focus-outline', '1');
}
hadMouseDown = false;
});
this.addEventListener('mousedown', () => {
this.style.setProperty('--uui-show-focus-outline', '0');
hadMouseDown = true;
});
this.addEventListener('mouseup', () => {
hadMouseDown = false;
});
}

connectedCallback() {
super.connectedCallback();
this.setAttribute('role', 'row');