Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global definitions everywhere #130

Merged
merged 7 commits into from
Feb 9, 2022
Merged

Global definitions everywhere #130

merged 7 commits into from
Feb 9, 2022
+613 −367

Conversation

iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Feb 7, 2022 •
edited
Loading

Description

This adds a few things to all packages:

  1. We now declare all elements directly from the element files
  2. We now define all elements directly from the element files, meaning the index.ts files no longer has any sideeffects, meaning that tree-shaking works better.

Fixes AB#17181

Fixes AB#17174

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and context

We now follow the intentions of the modernweb example repo

How to test?

npm run test
npm run build:prod

Checklist

  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@iOvergaard
AB#17174 Add declare global to all elements

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
108ec0c
@iOvergaard
AB#17181 Remove all index.ts calls to defineElement

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
b786b41
@iOvergaard
AB#17181 Convert defineElement to decorator and use in all elements a…

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
0b56e60 
…nd tests
@iOvergaard
Merge remote-tracking branch 'origin/dev' into feature/package-globals

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
ce3d48a
@iOvergaard iOvergaard marked this pull request as ready for review February 7, 2022 10:33
iOvergaard and others added 3 commits February 8, 2022 10:13
@iOvergaard
uui-toggle: Change customElement to defineElement

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
1963a98
@iOvergaard
uui-table: Remove global declaration for advanced-example

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
05081a6
@nielslyngsoe
run litCssPlugin after esbuild for ESmodule setup, was not needed for…
e32b71a 
… Bundling. Also use JSX syntax.
@nielslyngsoe nielslyngsoe merged commit 7925766 into dev Feb 9, 2022
@nielslyngsoe nielslyngsoe deleted the feature/package-globals branch February 9, 2022 12:09
@iOvergaard iOvergaard added the enhancement New feature or request label Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AB#17181 AB#17174
2 participants
@iOvergaard @nielslyngsoe