Fixes #9625 - Searching icons for "box" returns all icons #9848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarnef
changed the title
bjarnef
changed the title
nul800sebastiaan
added
community/pr
release/8.13.0
type/bug
category/ux
nul800sebastiaan
changed the title
|
Thanks again @bjarnef - good stuff! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #9625
Description
This PR fixes issues with filtering in icon picker and searching for terms like
box,viewandsvgbecause these are included in thesvgStringproperty. We only need to filter on name property. In future releases we might be able to filter on tags or similar - see #9122Btw in this GIF I have installed the Material Design Icon Pack, which doen't use SVG icons, but demonstrate the filtering also works with custom icons.
This is similar to other filtering where we are working with objects, e.g. in block picker where filter on "image" doesn't really filter anything as mentioned in #9831
We can look at this in another PR.