Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V16: Removed deprecated client-side code #18662

Draft
wants to merge 5 commits into
base: v16/dev
Choose a base branch
from

Conversation

leekelleher
Copy link
Member

Important

This PR will be in draft state until the client-side project has been reviewed for all deprecated code.

Description

In parallel to #18661 (for server code), this PR removes client code that has been marked for removal in Umbraco 16, (as well as Umbraco 15 that hadn't been removed).

/** @deprecated This property will be removed in Umbraco 15. */
submitLabel?: string;
}
export type UmbPropertyEditorUIPickerModalData = object;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that I'm guilty of doing this in other places. But it is more ideal to set this to never, as object is a bit of a vague type, not really helping the user. where 'never' makes it clear to the user that there is nothing to send here. :-)

/** @deprecated This property will be removed in Umbraco 15. */
submitLabel?: string;
}
export type UmbDataTypePickerFlowModalData = object;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, use never

Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lee for cleaning this up, I just have a minor optimization. :-)
The same thing about never could be updated for a few others if you don't mind checking for other Modal Tokens that uses object as their nothing type. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants