Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoids collection was modified issue when flowing identities to the authenticated user's principal #18527

Conversation

AndyButland
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

Resolves: #18509

Description

It looks as if #18206 introduced an issue in this situation, where you have a user authenticated via IIS basic authentication before attempting to sign-in to the backoffice.

I haven't been able to reproduce it using the public access feature on Umbraco Cloud.

I've been able to reproduce locally: #18509 (comment) - so these are the test steps.

When I try this process again with the code from this PR in place, I no longer see the issue.

Sorry, something went wrong.

…uthenticated user's principal.
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to reproduce locally and can't follow your steps since IIS doesn't run on Linux, however I have verified that the original issue is still fixed, so if you've tested it maybe we should just merge?

@AndyButland
Copy link
Contributor Author

Let's do that - I have verified it locally with IIS.

@AndyButland AndyButland merged commit 396b5ea into v13/dev Mar 4, 2025
20 checks passed
@AndyButland AndyButland deleted the v13/bugfix/fix-issue-with-iis-basic-auth-and-backoffice-login branch March 4, 2025 11:12
AndyButland added a commit that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants