Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V15: Adds validation on date from/to inputs in the schedule modal #18437

Merged
merged 1 commit into from
Feb 25, 2025
Merged

V15: Adds validation on date from/to inputs in the schedule modal #18437

merged 1 commit into from
Feb 25, 2025
+135 −59

Conversation

iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Feb 24, 2025 •
edited
Loading

Description

Adds the following validation to the date inputs:

  • Publish time cannot be in the user's past
  • Unpublish time cannot be in the user's past
  • Unpublish time cannot be before publish time

Fixes AB#49139

How to test

  1. Try to set different values in the dialog

Screenshots

image

@iOvergaard
feat: adds validation on date from/to inputs in the schedule modal

Verified

This commit was signed with the committer’s verified signature.
iOvergaard Jacob Overgaard
GPG key ID: 776F140E8C98F95E
Verified
Learn about vigilant mode
Loading
Loading status checks…
918ff78
@iOvergaard iOvergaard enabled auto-merge (squash) February 24, 2025 13:44
@iOvergaard iOvergaard merged commit c19b228 into v15/dev Feb 25, 2025
23 of 24 checks passed
@iOvergaard iOvergaard deleted the v15/feature/schedule-validation branch February 25, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher

Assignees
No one assigned
Labels
area/frontend category/ux User experience release/15.3.0 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AB#49139
2 participants
@iOvergaard @leekelleher