Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization for Approved color/Color Picker Data type #18411

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

DitteKKoustrup
Copy link
Contributor

Reson for change

The data type for Approved color/Color Picker, wasn't translated when I changed my Backoffice language to Danish.
I translated the missing translations into Danish to match the rest of the Danish Backoffice.

Description

  • Created a colorPickerConfigurations category to the code in the en.ts, en-us.ts, and da-dk.ts file
  • Added a translation for the label title and description and the color title and description.
  • Removed the hardcoded label in Umbraco.ColorPicker.ts and made it dynamic with the new colorPickerConfigurations category and key.

Image of change

Screenshot 2025-02-21 at 10 11 58

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (though just want to make sure we were using "proper" English😉).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Andy Butland <[email protected]>
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you've done here is working as expected, but for some reason I'm not seeing the UK English come through when I set my editor as using that language.

That's a wider issue though, not part of this PR, so approving and will merge in.

@AndyButland AndyButland merged commit a0ddaef into v15/dev Feb 21, 2025
23 checks passed
@AndyButland AndyButland deleted the ditte/approvedColorLocalization branch February 21, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants