Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V15: Update Backoffice NPM dependencies #18376

Merged
merged 33 commits into from
Feb 20, 2025
Merged

V15: Update Backoffice NPM dependencies #18376

merged 33 commits into from
Feb 20, 2025

Conversation

iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Feb 18, 2025 •
edited
Loading

Changes

  • Updates Backoffice dependencies.
  • Removed dependency base64-js - this code is now inlined and attributed to the original author, which allows us to export it as an esmodule
  • Removed dependency @rollup/commonjs-plugin - no longer needed due to base64-js
  • Removed dependency @web/dev-server-rollup - no longer needed due to base64-js
  • Added dependency svgo to optimise icons and ensure that we no longer need 550+ files changed in PRs when upgrading icon libraries
  • Added tests for generate:icons and generate:tsconfig in the Github Action to make sure icons work

How to test

  • Make sure to run npm run build:for:cms and launch the backend server
  • Test areas affected by or using Tinymce, Tiptap, Icons, Marked
  • Test Storybook

@iOvergaard
build(deps-dev): update storybook from 8.4.7 to 8.5.6

Verified

This commit was signed with the committer’s verified signature.
iOvergaard Jacob Overgaard
GPG key ID: 776F140E8C98F95E
Verified
Learn about vigilant mode
Loading
Loading status checks…
aa66e1e
@iOvergaard
build(deps): update tiptap from 2.11.2 to 2.11.5
8a0620e
@iOvergaard
build(deps-dev): update eslint stuff to latest
8d289bd
@iOvergaard
build(deps): update element-internals-polyfill from 1.3.12 to 1.3.13
8284043
@iOvergaard
build(deps): update marked from 15.0.6 to 15.0.7
09eeeaf
@iOvergaard
build(deps-dev): update vite from 5.4.14 to 6.1.0
977f7b8
@iOvergaard
build(deps-dev): update globals to 15.15.0 (eslint dependency)
1efd603
@iOvergaard
build(deps): update icon libraries to latest
8330be1
@iOvergaard
build(deps-dev): update prettier from 3.4.2 to 3.5.1
c19d64a
@iOvergaard
chore: generate consts
d8aaee8
@iOvergaard
build(deps-dev): update test-related libraries
fa91a9b
@iOvergaard
feat: copy over code from the tiny base64-js library because it is no…
ad6ca82 
…t exported as esm and has not been updated in 4 years
@iOvergaard
build(deps-dev): remove dependency from base64-js
435a542
@iOvergaard
build(deps-dev): upgrade rollup dependencies
f43f0ec
@iOvergaard
test: disable tests for tinyce
f99f6b6
@iOvergaard
build(deps-dev): update @babel/core to 7.26.9
6700fa3
@iOvergaard
build(deps): update storybook to latest
b654631
@iOvergaard
build(deps-dev): update types
33f88d0
@iOvergaard
build(deps-dev): update typedoc from 0.27.6 to 0.27.7
9bab388
@iOvergaard
build(deps-dev): update @rollup/plugin-commonjs to latest
e5a40f4
@iOvergaard
build(deps): import tiny as default and re-export as module and defau…
3e7a5b3 
…lt to make everyone happy (and avoid commonjs pitfalls)
@iOvergaard
build: remove dependency on commonjs to build externals
d9dc5f1
@iOvergaard
build(deps-dev): uninstall @rollup/plugin-commonjs as it is no longer…
3d8d487 
… needed
@iOvergaard
test: reenable tinymce tests
db5c34a
@iOvergaard
fix: sets a default label
603d913 
this mistake was highlighted by the test runner
@iOvergaard
test: reenable tinymce tests
f67cf6f
@iOvergaard
build: ignores autogenerated test file
fabb0c5
@iOvergaard
build: adds github error logging to icon generator
42bda99
@iOvergaard
build: log as error
5244f08
@iOvergaard
build: adds tests for generate:* scripts
26011b4
@iOvergaard
build: optimises icons with svgo to remove useless things like comments
6206020 
this also ensures that icons are unchanged when we upgrade icon library packages as they would normally include things like versions as comments in the files
@iOvergaard iOvergaard added dependencies Pull requests that update a dependency file area/frontend release/15.3.0 labels Feb 19, 2025
@iOvergaard iOvergaard marked this pull request as ready for review February 19, 2025 11:07
@iOvergaard iOvergaard enabled auto-merge (squash) February 19, 2025 11:07
leekelleher
leekelleher approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, everything is working as expected! 🚀

@iOvergaard iOvergaard merged commit 7a7602f into v15/dev Feb 20, 2025
22 of 23 checks passed
@iOvergaard iOvergaard deleted the v15/feature/client-npm-2025-02 branch February 20, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher

Assignees
No one assigned
Labels
area/frontend dependencies Pull requests that update a dependency file release/15.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iOvergaard @leekelleher