Modified AspNetCoreRequestAccessor to gracefully handle the absence of an HttpContext #18369
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eable content when publishing in a background task.
…for routeable content when publishing in a background task." This reverts commit 953a795.
Migaroez
approved these changes
Feb 19, 2025
AndyButland
changed the title
AndyButland
deleted the
v15/bugfix/fix-exception-thrown-with-scheduled-publishing-in-background-task
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes: 18366
Description
The linked issue revealed an exception thrown after scheduled publishing, triggered via a notification handler implemented to provide warnings to the editor in the case of unrouteable content. This logic needs makes use of
AspNetCoreRequestAccessor, that requires anHttpContext, which it doesn't have in scheduled publishing due to this running in a background task.There is actually no reason to use
GetRequiredHttpContexthere as where it's used to retrieve the querystring or form value, it can correctly return a null value (as if there is noHttpContext, there's noRequestand hence no querystring or form values).To test here I've put a debugger in the notification handler, and successfully stepped through a scheduled publish operation with no exception.