-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Display current variant item name #18311
Merged
nielslyngsoe
merged 69 commits into
v15/dev
from
v15/feature/display-current-variant-item-name
Feb 18, 2025
Merged
Feature: Display current variant item name #18311
nielslyngsoe
merged 69 commits into
v15/dev
from
v15/feature/display-current-variant-item-name
Feb 18, 2025
+442
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Loading status checks…
…/display-current-variant-item-name
Base automatically changed from
v15/feature/entity-item-ref-extension
to
v15/dev
February 13, 2025 10:15
Loading status checks…
…name
Loading status checks…
…name
Loading status checks…
…name
Loading status checks…
…name
src/Umbraco.Web.UI.Client/src/packages/documents/documents/item/document-item-ref.element.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/documents/documents/item/document-item-ref.element.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/documents/documents/item/document-item-ref.element.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/documents/documents/item/document-item-ref.element.ts
Outdated
Show resolved
Hide resolved
nielslyngsoe
approved these changes
Feb 18, 2025
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17652
This PR introduces an UmbDocumentItemDataResolver to assist in gathering context-aware names + states for document items.
This means that the resolver will return the correct name, state, and create/update dates based on the current language context.
The PR implements the resolver in the
What to test:
Show the correct name/state when: