Fixing adding properties to inherited Group #17695 #18285
Merged
+35
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsrasmussen
requested changes
Feb 12, 2025
|
HI @madsrasmussen well spotted, It took some time for me to find the problem — it was the Helper that moves Groups from Root to newly created Tabs that was causing the trouble. Before it was observing for such action, but now I changed it so its only there when the user creates its first tab. So everything should be good now :-) |
nielslyngsoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17695
Issue was grounded in the modal begin unregistered as the property Group was cloned to the local Document Type, and thereby unregistering the modal as a new one with the newly created group id was registered.
This PR fixes to modal that are begin removed and are active will be closed in that act.