Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 11643 #18257

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix 11643 #18257

merged 1 commit into from
Feb 7, 2025

Conversation

nielslyngsoe
Copy link
Member

Fixes #11643

After Blocks was added to the Rich text Editor, the built-in Mandatory validation check has no effect, as we always will have a Object.

This adds a custom validation to check for the markup field, and thereby ensure that we have markup when a field is mandatory.

This fix is not viable to cherry pick for previous versions as the data model of the Rich Text editor was changed in v.13.

See issue for test cases

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested and confirmed that this resolves the issue:

image

@AndyButland AndyButland removed their assignment Feb 7, 2025
@nielslyngsoe nielslyngsoe merged commit 4ca68d6 into v13/dev Feb 7, 2025
19 of 20 checks passed
@nielslyngsoe nielslyngsoe deleted the v13/bugfix/11643 branch February 7, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants