Corrected rendering of member type icons on create button and picker #18203
+27
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leekelleher
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Tested out, working as expected! 🚀
I'd noticed that the Member Picker didn't have the correct icon for the picked items, so I've updated this PR with that fix.
Also noticed that the Member Picker modal search doesn't display the correct icon in the results, but that's a larger fix, (raised in #17664), I'm working on a general fix for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Resolves: #17022
Description
There are a few issues raised with member icons on the linked issue. Some appear to have already been resolved but I could see that:
These are both resolved with this PR: