-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V15: Client should validate maxFileSize and allowed/disallowed file types from server configuration #18163
Merged
iOvergaard
merged 41 commits into
v15/dev
from
v15/feature/temporary-file-configuration
Jan 30, 2025
Merged
V15: Client should validate maxFileSize and allowed/disallowed file types from server configuration #18163
iOvergaard
merged 41 commits into
v15/dev
from
v15/feature/temporary-file-configuration
Jan 30, 2025
+299
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mick the OpenAPI generator
…cate upload status
… able to show the progress in percent
Loading status checks…
…re/temporary-file-configuration
…ary-file-configuration
leekelleher
reviewed
Jan 29, 2025
src/Umbraco.Web.UI.Client/src/packages/core/utils/bytes/bytes.function.ts
Outdated
Show resolved
Hide resolved
Loading status checks…
…function.ts Co-authored-by: Lee Kelleher <[email protected]>
leekelleher
reviewed
Jan 30, 2025
src/Umbraco.Web.UI.Client/src/packages/core/temporary-file/temporary-file-manager.class.ts
Outdated
Show resolved
Hide resolved
Loading status checks…
leekelleher
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out, working great! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fail early if file upload exceeds certain parameters.
Changes
Caveats
How to test
Runtime::MaxRequestLength
to something like51200
(50 MB) and try to upload an image larger than that. It should now warn you that the image is too large in the media picker, RTE, media library, etc, and it should NOT make a server request.Content::DisallowedUploadedFileExtensions
to something like["exe"]
and try to upload a .exe file, check that a warning is shown to the user and NO request is sent.