Added a check that we have a route before attempting to include it in the other URLs for a published document #18135
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the other URLs for a published document.
nikolajlauridsen
approved these changes
Jan 28, 2025
nikolajlauridsen
deleted the
v15/bugfix/fix-unpublished-culture-in-get-other-urls
branch
nikolajlauridsen
pushed a commit
that referenced
this pull request
Jan 28, 2025
… the other URLs for a published document. (#18135)
|
Cherry-picked to 15.2 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes: #18130
Description
Looks like we had an issue here with the code that has a null check for if a route is found for a given node and culture, but it wasn't checking for a result of "#", which is the actual value returned when a route isn't found.
Should be cherry-picked to the release branch when approved and merged, as it's a regression from 15.1.