Feature: Tiptap: Generic markup support #18124
Merged
+230
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to add `class`, `id` and `data-*` attributes to any markup within Tiptap contents.
to support generic markup modifications.
to support generic markup modifications. Also modifies "umbEmbeddedMedia" to check explicitly for the `umb-embed-holder` class name. This is to differentiate from the generic `div` tag.
Previously this was a faux extension, but it is now real. This extension adds the core extensions for Umbraco RTE support. e.g. StarterKit, et al, and the new global attributes and generic elements.
iOvergaard
reviewed
Jan 27, 2025
@iOvergaard Sounds good. 👍 |
|
@iOvergaard It appears to play nicely with the text-alignment extension. I was concerned that the Markup (in View Source Code modal) Rendered (in Tiptap RTE) Not that I'd actively encourage inline CSS styles within the RTE, but the option is there. |
so that it can allow other (nested) `Mark` extensions.
iOvergaard
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17832.
Adds support for generic markup tags (e.g.
divandspan) and global attributes (e.g.class,id, anddata-*).This PR introduces a "Rich Text Essentials" Tiptap extension, this was originally a fake extension to encapsulate the core Tiptap extensions required for use in Umbraco, but with the addition of the generic extensions, it has become real.
It has been developed in a backwards-compatible way, no breaking-changes.
How to test?
class,idordata-*attributes, and throw in a few<div>and<span>tags.Do keep in mind that Tiptap is a semantic rich-text editor and will evaluate the markup presented: e.g. it will not allow Block elements within Inline elements, e.g.
<span><div></div></span>; and attributes may be re-ordered alphabetically.